Skip to content

feat: removed-feature-key-and-segment-key-from-schema #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: removed-feature-key-and-segment-key-from-schema #210

wants to merge 6 commits into from

Conversation

@Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Oct 23, 2025 •
edited by matthewelwell
Loading

  • Removed FeatureContext.feature_key and use FeatureContext.name for override matching
  • Removed SegmentResult.key
  • Harmonized FeatureMetadata.flagsmithId to FeatureMetadata.flagsmith_id
  • Used Generic for segments to require metadata.flagsmith_id
  • Re-organized evaluation/models.ts

Contributes to #209

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner October 23, 2025 14:42
@Zaimwa9 Zaimwa9 requested review from emyller and removed request for a team October 23, 2025 14:42
Zaimwa9
Zaimwa9 commented Oct 23, 2025
View reviewed changes
Zaimwa9
Zaimwa9 commented Oct 23, 2025
View reviewed changes
package.json Outdated
Comment on lines 61 to 62
"generate-evaluation-result-types": "curl -o evaluation-result.json https://raw.githubusercontent.com/Flagsmith/flagsmith/chore%2Fevaluation-context0key/sdk/evaluation-result.json && npx json2ts -i evaluation-result.json -o flagsmith-engine/evaluation/evaluationResult/evaluationResult.types.ts && rm evaluation-result.json",
"generate-evaluation-context-types": "curl -o evaluation-context.json https://raw.githubusercontent.com/Flagsmith/flagsmith/chore%2Fevaluation-context0key/sdk/evaluation-context.json && npx json2ts -i evaluation-context.json -o flagsmith-engine/evaluation/evaluationContext/evaluationContext.types.ts && rm evaluation-context.json",
Copy link
Contributor Author

@Zaimwa9 Zaimwa9 Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revert once merged

@Zaimwa9 Zaimwa9 requested a review from gagantrivedi October 23, 2025 16:04
gagantrivedi
gagantrivedi previously requested changes Oct 24, 2025
View reviewed changes
@Zaimwa9 Zaimwa9 requested a review from gagantrivedi October 24, 2025 09:25
@Zaimwa9 Zaimwa9 requested a review from khvn26 October 27, 2025 12:31
khvn26
khvn26 approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khvn26 khvn26 dismissed gagantrivedi’s stale review October 30, 2025 16:41

The remaining thread was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khvn26 khvn26 khvn26 approved these changes

@emyller emyller Awaiting requested review from emyller emyller is a code owner automatically assigned from Flagsmith/flagsmith-back-end

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zaimwa9 @khvn26 @gagantrivedi